<?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0"
	xmlns:content="http://purl.org/rss/1.0/modules/content/"
	xmlns:wfw="http://wellformedweb.org/CommentAPI/"
	xmlns:dc="http://purl.org/dc/elements/1.1/"
	xmlns:atom="http://www.w3.org/2005/Atom"
	xmlns:sy="http://purl.org/rss/1.0/modules/syndication/"
	xmlns:slash="http://purl.org/rss/1.0/modules/slash/"
	>

<channel>
	<title>Technicalities &#187; review</title>
	<atom:link href="http://www.sirena.org.uk/log/tag/review/feed/" rel="self" type="application/rss+xml" />
	<link>http://www.sirena.org.uk/log</link>
	<description>Just another random blog</description>
	<lastBuildDate>Sat, 21 Jan 2012 23:41:17 +0000</lastBuildDate>
	<language>en</language>
	<sy:updatePeriod>hourly</sy:updatePeriod>
	<sy:updateFrequency>1</sy:updateFrequency>
	<generator>http://wordpress.org/?v=3.3.1</generator>
		<item>
		<title>What&#8217;s wrong with switch statements?</title>
		<link>http://www.sirena.org.uk/log/2011/12/20/whats-wrong-with-switch-statements/</link>
		<comments>http://www.sirena.org.uk/log/2011/12/20/whats-wrong-with-switch-statements/#comments</comments>
		<pubDate>Tue, 20 Dec 2011 13:24:55 +0000</pubDate>
		<dc:creator>Mark Brown</dc:creator>
				<category><![CDATA[Linux]]></category>
		<category><![CDATA[Planet Debian]]></category>
		<category><![CDATA[tech]]></category>
		<category><![CDATA[C]]></category>
		<category><![CDATA[code]]></category>
		<category><![CDATA[code review]]></category>
		<category><![CDATA[kernel]]></category>
		<category><![CDATA[review]]></category>

		<guid isPermaLink="false">http://www.sirena.org.uk/log/?p=463</guid>
		<description><![CDATA[Recently I&#8217;ve been noticing a surprising pattern in code I&#8217;m reviewing for the kernel. A lot of people seem to have taken to writing code that I&#8217;d expect to look like this: switch (thing) { case VALUE: /* Stuff */ break; case BAR: /* Nonsense */ break; default: /* Whatever */ break; } with if [...]]]></description>
			<content:encoded><![CDATA[<p>Recently I&#8217;ve been noticing a surprising pattern in code I&#8217;m reviewing for the kernel. A lot of people seem to have taken to writing code that I&#8217;d expect to look like this:</p>
<pre>switch (thing) {
case VALUE:
        /* Stuff */
        break;
case BAR:
        /* Nonsense */
        break;
default:
        /* Whatever */
        break;
}</pre>
<p>with if statements instead:</p>
<pre>if (thing == VALUE) {
        /* Stuff */
} else if (thing == BAR) {
        /* Nonsense */
} else {
        /* Whatever */
}</pre>
<p>(where stuff, nonsense and whatever are usually a bit larger). I really don&#8217;t understand where this has come from &#8211; the if based form isn&#8217;t nearly so idiomatic for selecting between a range of values and this seems to have come from nowhere pretty much. Is there some code base out there where this is common practice or something?</p>
]]></content:encoded>
			<wfw:commentRss>http://www.sirena.org.uk/log/2011/12/20/whats-wrong-with-switch-statements/feed/</wfw:commentRss>
		<slash:comments>13</slash:comments>
		</item>
		<item>
		<title>Chasing patches into Linux</title>
		<link>http://www.sirena.org.uk/log/2009/09/05/chasing-patches-into-linux/</link>
		<comments>http://www.sirena.org.uk/log/2009/09/05/chasing-patches-into-linux/#comments</comments>
		<pubDate>Sat, 05 Sep 2009 17:58:11 +0000</pubDate>
		<dc:creator>Mark Brown</dc:creator>
				<category><![CDATA[Linux]]></category>
		<category><![CDATA[Planet Debian]]></category>
		<category><![CDATA[tech]]></category>
		<category><![CDATA[community]]></category>
		<category><![CDATA[development]]></category>
		<category><![CDATA[review]]></category>
		<category><![CDATA[social]]></category>

		<guid isPermaLink="false">http://www.sirena.org.uk/log/?p=60</guid>
		<description><![CDATA[One thing that often seems to cause problems for people who work over many different areas of the Linux kernel is the process of making sure that patches actually get reviewed and applied. Where the relevant subsystem is actively maintained it&#8217;s not a problem but that&#8217;s not always the case. Sometimes maintainers are busy or [...]]]></description>
			<content:encoded><![CDATA[<p>One thing that often seems to cause problems for people who work over many different areas of the Linux kernel is the process of making sure that patches actually get reviewed and applied. Where the relevant subsystem is actively maintained it&#8217;s not a problem but that&#8217;s not always the case. Sometimes maintainers are busy or on holiday and miss things, sometimes there are other problems. In these cases the onus is on the patch submitter to spot the problem and make sure that something is done to ensure that the patch doesn&#8217;t get forgotten.</p>
<p>There&#8217;s a few  workflows for dealing with this. My preferred one is to track the appearance of my patches in Stephen Rothwell&#8217;s <a href="http://git.kernel.org/?p=linux/kernel/git/eranian/linux-next.git;a=summary">linux-next</a> tree, which tracks individual development trees destined for merge into Linus&#8217; tree. I create a git branch based on the current state of this tree then apply the patches I&#8217;m submitting on top of that. This lets me spot any potential merge conflicts that they&#8217;ll create but the main function is to allow me to come back to the branch later and track which of the patches has shown up in one of the trees that Stephen tracks. To do this I rebase the branch onto the current state of linux-next:</p>
<blockquote>
<pre>git rebase --onto next/master old-master</pre>
</blockquote>
<p>where &#8216;old-master&#8217; is the last linux-next commit in the branch. This will flag up any merge issues that have come up due to changes in other trees and will also handle patches that are already present in one of the trees in -next by dropping my local version. The end result is a branch based on the new linux-next with all the patches that were not yet applied in it. I can see what still needs to be looked at by examining the log</p>
<blockquote>
<pre>git shortlog next/master..</pre>
</blockquote>
<p>and take any appropriate action, such as following up with the relevant maintainer or trying to find out what&#8217;s going on with the subsytem if it looks like the subsystem maintainers are inactive.</p>
<p>One possible problem with this approach is that a patch may be applied and then subsequently dropped &#8211; this is rare but it can happen. I deal with that by also keeping a normal unrebased development branch whch has the changes in Linus&#8217; tree merged  into it periodically and incremental patches for any review updates that occur during the submission process. By looking at the diff between that and other trees I can see any changes that have got lost along the way.</p>
]]></content:encoded>
			<wfw:commentRss>http://www.sirena.org.uk/log/2009/09/05/chasing-patches-into-linux/feed/</wfw:commentRss>
		<slash:comments>0</slash:comments>
		</item>
		<item>
		<title>Festen</title>
		<link>http://www.sirena.org.uk/log/2008/11/03/festen/</link>
		<comments>http://www.sirena.org.uk/log/2008/11/03/festen/#comments</comments>
		<pubDate>Mon, 03 Nov 2008 21:25:21 +0000</pubDate>
		<dc:creator>Mark Brown</dc:creator>
				<category><![CDATA[Film]]></category>
		<category><![CDATA[Reviews]]></category>
		<category><![CDATA[dogma 95]]></category>
		<category><![CDATA[review]]></category>

		<guid isPermaLink="false">http://www.sirena.org.uk/log/?p=148</guid>
		<description><![CDATA[One of my recent DVD acquisitions was Festen, the first of the Dogma 95 films. In spite of not having seen the film since it came out more than a decade ago (though I did re-watch it once then after first seeing it at the EIFF) it&#8217;s been one of the films I think back [...]]]></description>
			<content:encoded><![CDATA[<p>One of my recent DVD acquisitions was Festen, the first of the Dogma 95 films. In spite of not having seen the film since it came out more than a decade ago (though I did re-watch it once then after first seeing it at the EIFF) it&#8217;s been one of the films I think back on most frequently so as soon as I saw that it was going to be released again I preordered it.</p>
<p>This being a Dogma 95 film there is little need to wait for a HD version &#8211; the Dogma rules are all about getting back to basics including all-natural lighting and handheld camerawork done with low end cameras. This means there&#8217;s really not any detail to miss, instead there&#8217;s a visceral, documentary style feel. Really the film is all one big sequence of formal exercises &#8211; the Dogma rules are obviously a big formalism, the plot is very Jacobean and the whole thing revolves around a rather grand birthday party with bow ties and a toastmaster. The thing that really hooks me is the contrast between all this formality and the content, which is fairly brutal and emphasised by the visual style. I find this sort of setup endlessly fascinating when it&#8217;s done well.</p>
]]></content:encoded>
			<wfw:commentRss>http://www.sirena.org.uk/log/2008/11/03/festen/feed/</wfw:commentRss>
		<slash:comments>0</slash:comments>
		</item>
		<item>
		<title>EIFF 2008</title>
		<link>http://www.sirena.org.uk/log/2008/09/14/eiff-2008/</link>
		<comments>http://www.sirena.org.uk/log/2008/09/14/eiff-2008/#comments</comments>
		<pubDate>Sun, 14 Sep 2008 21:27:22 +0000</pubDate>
		<dc:creator>Mark Brown</dc:creator>
				<category><![CDATA[EIFF]]></category>
		<category><![CDATA[Film]]></category>
		<category><![CDATA[Planet Debian]]></category>
		<category><![CDATA[Reviews]]></category>
		<category><![CDATA[Errol Morris]]></category>
		<category><![CDATA[review]]></category>
		<category><![CDATA[Werner Hertzog]]></category>

		<guid isPermaLink="false">http://www.sirena.org.uk/log/?p=124</guid>
		<description><![CDATA[It&#8217;s been so long since the film festival that I keep on forgetting half the good films I saw there when talking to people about it, so for the record here&#8217;s a brief list of my personal highlights: Encounters at the End of the World: Werner Hertzog goes to Antarctica, making a film more about [...]]]></description>
			<content:encoded><![CDATA[<p>It&#8217;s been so long since the <a href="http://www.edfilmfest.org.uk/">film festival</a> that I keep on forgetting half the good films I saw there when talking to people about it, so for the record here&#8217;s a brief list of my personal highlights:</p>
<ul>
<li><a href="http://encountersfilm.com/">Encounters at the End of the World</a>: Werner Hertzog goes to Antarctica, making a film more about the sort of people who end up spending their time there than about anything else. Though there are suicidal penguins.</li>
<li><a href="www.youtube.com/watch?v=ctfsELU3TSU">Mum and Dad</a>: If you like this sort of thing the chances are you&#8217;ll think it&#8217;s brilliant. You may, however, still agree with the other people who don&#8217;t like this sort of thing and might describe it as being sick and wrong.</li>
<li>Standard Operating Procedure: I <a href="http://www.sirena.org.uk/log/2008/07/20/standard-operating-procedure/">blogged about this at the time</a>; <a href="http://errolmorris.com/">Errol Morris</a> covers Abu Ghraib and does it very well.</li>
<li><a href="http://www.cinematical.com/2008/01/26/sundance-review-just-another-love-story/">Just Another Love Story</a>: I really enjoyed this when I saw it, though I do agree with most of the linked review. It&#8217;s a noirish thriller with three different time periods in the story being revealed in parallel. It looks gorgeous, it&#8217;s very well executed but I&#8217;m hesitant since I think I may feel differently when I see it again.</li>
<li><a href="http://www.cinematical.com/2008/01/21/sundance-review-good-dick/">Good Dick</a>: In broad terms this is a very messed up take on a romantic comedy, more messed up than I believe it&#8217;s really intended to be (if you see it, think about what&#8217;s actually going on in the story). I enjoyed it for this and the contrast with the immediate tone but it&#8217;s not for everyone.</li>
</ul>
<p>As far as the EIFF moving to June goes&#8230; I&#8217;m not convinced. I didn&#8217;t notice any dramatic improvement in the quality of the programme and while it did avoid the rain that Edinburgh suffered in August there&#8217;s nothing quite like the atmosphere you get during the main festival.</p>
]]></content:encoded>
			<wfw:commentRss>http://www.sirena.org.uk/log/2008/09/14/eiff-2008/feed/</wfw:commentRss>
		<slash:comments>0</slash:comments>
		</item>
		<item>
		<title>Paradoxical Undressing</title>
		<link>http://www.sirena.org.uk/log/2008/08/22/paradoxical-undressing/</link>
		<comments>http://www.sirena.org.uk/log/2008/08/22/paradoxical-undressing/#comments</comments>
		<pubDate>Fri, 22 Aug 2008 08:28:02 +0000</pubDate>
		<dc:creator>Mark Brown</dc:creator>
				<category><![CDATA[Reviews]]></category>
		<category><![CDATA[festival]]></category>
		<category><![CDATA[Kristin Hersh]]></category>
		<category><![CDATA[live]]></category>
		<category><![CDATA[review]]></category>
		<category><![CDATA[Throwing Muses]]></category>

		<guid isPermaLink="false">http://www.sirena.org.uk/log/?p=100</guid>
		<description><![CDATA[Paradoxical Undressing is a mostly spoken word show by Throwing Muses/50 Foot Wave front woman Kristin Hersh. A series of ten minute autobiographical fragments covering the time up until about the first Throwing Muses album read over guitar riffs, interspersed with excerpts from songs (mostly hers but a couple of covers). The texts have much [...]]]></description>
			<content:encoded><![CDATA[<p><a href="http://www.kristinhersh.com/the-fringe-festival">Paradoxical Undressing</a> is a mostly spoken word show by <a href="http://throwingmusic.com/">Throwing Muses</a>/50 Foot Wave front woman <a href="http://kristinhersh.com/">Kristin Hersh</a>. A series of ten minute autobiographical fragments covering the time up until about the first Throwing Muses album read over guitar riffs, interspersed with excerpts from songs (mostly hers but a couple of covers).</p>
<p>The texts have much of the obliqueness of her songwriting, made less obscure by the extra room for explanation that the extended form allows. Everything is apparently impressionistic and naive but expertly wrapped up and structured, with a wry humour taking the edge off the darker material and showing self knowledge that gives a great degree of insight into the experiences being described. Most of this text has been mailed (out on a mailing list I can&#8217;t find a link for right now) so it was familiar. The performance added a lot &#8211; Kristin has great timing and delivery, adding a lot of warmth to the proceedings.</p>
<p>Much of this has been covered in detail in <a href="http://www.hydragenic.com/2008/03/31/kristin_hersh_paradoxical_undressing/">other reviews</a> but one of the things that particularly struck a chord with me which I don&#8217;t think I&#8217;ve heard anyone articulate particularly clearly was the description of talking to other people who were doing music and realising that there were people who just didn&#8217;t get it, who just did things and didn&#8217;t really connect with what they were doing in any meaningful way. There are some things that seem so natural and obvious that it causes quite a bit of cognitive dissonance when you realise that it&#8217;s not so for everyone &#8211; in my case it&#8217;s been things like abstraction and the engineering idea of elegance but I&#8217;m fairly sure that this is actually a universal experience. I believe there are some people with hand eye coordination and stuff.</p>
<p>The only reservation I had was with the music. Since I knew most of the songs the musical interludes were a bit frustrating at times &#8211; I kept on being disappointed when the second verses failed to appear. Of course, this probably doesn&#8217;t peg me as the most critical observer of her work so you might want to take what I say with a pinch of salt.</p>
]]></content:encoded>
			<wfw:commentRss>http://www.sirena.org.uk/log/2008/08/22/paradoxical-undressing/feed/</wfw:commentRss>
		<slash:comments>0</slash:comments>
		</item>
		<item>
		<title>My Blueberry Nights</title>
		<link>http://www.sirena.org.uk/log/2008/03/09/my-blueberry-nights/</link>
		<comments>http://www.sirena.org.uk/log/2008/03/09/my-blueberry-nights/#comments</comments>
		<pubDate>Sun, 09 Mar 2008 12:56:15 +0000</pubDate>
		<dc:creator>Mark Brown</dc:creator>
				<category><![CDATA[Film]]></category>
		<category><![CDATA[Reviews]]></category>
		<category><![CDATA[2046]]></category>
		<category><![CDATA[In the Mood for Love]]></category>
		<category><![CDATA[review]]></category>
		<category><![CDATA[Wong Kar Wai]]></category>

		<guid isPermaLink="false">http://www.sirena.org.uk/log/?p=74</guid>
		<description><![CDATA[I saw Wong Kar Wai&#8217;s new film My Blueberry Nights a week or two back. It has had fairly poor reviews, mostly criticising the film for being insubstantial but pretty. This is fair comment but the reviews seem much harsher than is deserved &#8211; the film really is gorgeous and it never felt like it [...]]]></description>
			<content:encoded><![CDATA[<p>I saw Wong Kar Wai&#8217;s new film My Blueberry Nights a week or two back. It has had <a href="http://www.variety.com/index.asp?layout=festivals&#038;jump=review&#038;reviewid=VE1117933646&#038;cs=1">fairly</a> <a href="http://film.guardian.co.uk/cannes2007/story/0,,2080900,00.html">poor</a> <a href="http://www.timeout.com/film/reviews/84195/my-blueberry-nights.html">reviews</a>, mostly criticising the film for being insubstantial but pretty. This is fair comment but the reviews seem much harsher than is deserved &#8211; the film really is gorgeous and it never felt like it was trying to do more than it did. There&#8217;s some very off the shelf elements but it&#8217;s all at the same level as genre fiction, something you&#8217;re being asked to buy into to allow the rest of the work to flow. Not something I&#8217;d consider atypical for one of his films &#8211; 2046, for example, had similar issues with its fractured plot getting in the way of engagement. The reviews feel like the critics were expecting something of the calibre of In the Mood for Love and are taking out their disappointment on My Blueberry Nights.</p>
]]></content:encoded>
			<wfw:commentRss>http://www.sirena.org.uk/log/2008/03/09/my-blueberry-nights/feed/</wfw:commentRss>
		<slash:comments>0</slash:comments>
		</item>
		<item>
		<title>In Search of a Midnight Kiss</title>
		<link>http://www.sirena.org.uk/log/2007/09/26/in-search-of-a-midnight-kiss/</link>
		<comments>http://www.sirena.org.uk/log/2007/09/26/in-search-of-a-midnight-kiss/#comments</comments>
		<pubDate>Wed, 26 Sep 2007 17:49:58 +0000</pubDate>
		<dc:creator>Mark Brown</dc:creator>
				<category><![CDATA[EIFF]]></category>
		<category><![CDATA[Film]]></category>
		<category><![CDATA[Reviews]]></category>
		<category><![CDATA[2 Days in Paris]]></category>
		<category><![CDATA[Alex Holdridge]]></category>
		<category><![CDATA[In Search of a Midnight Kiss]]></category>
		<category><![CDATA[Kevin Smith]]></category>
		<category><![CDATA[review]]></category>
		<category><![CDATA[romantic comedy]]></category>

		<guid isPermaLink="false">http://www.sirena.org.uk/log/?p=57</guid>
		<description><![CDATA[It&#8217;s new year&#8217;s eve in Los Angeles; Wilson and Vivian have met as a result of a craigslist advert posted earlier in the day. He&#8217;s had a terrible year &#8211; his attempts to pursue his dreams started to go wrong before he even reached the city &#8211; and as we find out during the film [...]]]></description>
			<content:encoded><![CDATA[<p>It&#8217;s new year&#8217;s eve in Los Angeles; Wilson and Vivian have met as a result of a craigslist advert posted earlier in the day. He&#8217;s had a terrible year &#8211; his attempts to pursue his dreams started to go wrong before he even reached the city &#8211; and as we find out during the film she has her own troubles. They meander around downtown Los Angeles, chatting, flirting and bickering away.</p>
<p>The script and acting both share many of the best elements of <a href="http://www.silentbobspeaks.com/">Kevin Smith&#8217;s</a> work, being very funny but in the context of a real drama with engaging and very real characters. The humour is never a result of consequenceless gags &#8211; the characters say and do things that are funny but this always feels natural and if what they&#8217;re doing is not actually terribly clever it&#8217;s obvious that they feel the results.</p>
<p>This would make for a very good movie even if that were all that was going on (it might be something close to <a href="http://www.imdb.com/title/tt0841044/">2 Days in Paris</a>, another great movie that was at the <a href="http://www.edfilmfest.org.uk/">Edinburgh Film Festival</a> this year) but the way the film is shot adds an extra something. Everything is <a href="http://www.youtube.com/watch?v=3gM3P79oC9s">shot in a clean 1940s black and white</a>, complete with soft focus for the leading lady, and manages to make LA appear beautiful in a way that it rarely does. The visual style softens some of the hard edges that the script has &#8211; there&#8217;s a constant reminder of a fundamentally <em>nice</em> kind of film, making everything feel much warmer than it might have done. This warmth is the main thing I took away from the film and judging from the atmosphere in the room during the Q&amp;A afterwards I don&#8217;t think I was alone.</p>
<p><a href="http://www.insearchofamidnightkiss.com/">The film</a> being released in cinemas in the US on Valentine&#8217;s Day 2008, hopefully it&#8217;ll get a cinema release over here too. Seeing it in the cinema is may be the only chance to see the original black and white version &#8211; a colourised version is being prepared for the DVD release, though I hope that both versions will be included.</p>
]]></content:encoded>
			<wfw:commentRss>http://www.sirena.org.uk/log/2007/09/26/in-search-of-a-midnight-kiss/feed/</wfw:commentRss>
		<slash:comments>1</slash:comments>
		</item>
	</channel>
</rss>

